Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only report tasklogger is running if both stdout and stderr are still running #8155

Merged
merged 2 commits into from
Jun 12, 2020

Conversation

drewbailey
Copy link
Contributor

If stdout or stderr encounters EOF during their copy, we currently require both stdout and stderr to report as not running in order to close and start again.

This changes the check so that if either are closed or have finished copying we will restart the copy

Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Minor suggestions - cleaner than the alternative approach - thanks for the follow up.

client/logmon/logmon.go Outdated Show resolved Hide resolved
client/logmon/logmon.go Outdated Show resolved Hide resolved
@drewbailey drewbailey merged commit 9ffbb27 into master Jun 12, 2020
@drewbailey drewbailey deleted the bug/logmon-isrunning branch June 12, 2020 13:17
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants